Re: RFC: UIO null parent for __uio_register_device anduio_device_name()

[Hans J. Koch]

On Tue, Jan 18, 2011 at 07:56:52PM -0800, Earl Chew wrote:
> Hans,

Hi Earl,

> 
> I had a two UIO changes queued up from earlier which I
> forgot to ask you about.
> 
> Would you consider these changes for inclusion in the mainline ?
> 
> 
> o Allow a null parent during uio_register_device. We've had
>   situations where there was no convenient parent. We could
>   concoct a parent, but it seemed to make sense to allow
>   for a null.

Hmm. I saw many UIO drivers over the years but we never had that
problem. In the probe() function of your UIO driver you get a
suitable device as parameter. Why don't you just use it?

> 
> o Introduce uio_device_name() to allow callers to query for the
>   name of the created uio device. Without this, there doesn't seem
>   to be a straightforward way for a client to figure out the name of the
>   device.

Yes, we intentionally defined struct uio_device in uio.c and not in
a header file to prevent driver authors from using it ;-)

> 
> --- /tmp/uio.c.orig     2011-01-18 17:38:17.157452875 -0800
> +++ /tmp/uio.c  2011-01-18 19:46:48.367453578 -0800
> @@ -808,6 +808,18 @@
>  }
> 
>  /**
> + * uio_device_name - obtain the name of the registered device
> + * @info:      UIO device capabilities
> + *
> + * returns name of device.
> + */
> +const char *uio_device_name(struct uio_info *info)
> +{
> +       return dev_name(info->uio_dev->dev);

No NULL checks? Note that info->uio_dev can be NULL if uio_register_device()
failed...

> +}
> +EXPORT_SYMBOL_GPL(uio_device_name);

The function above returns strings like "uio0", "uio1", and so on. What's
the value of that? To identify a certain driver or distinguish several
instances of it, the "name" member of struct uio_info should be used.

But maybe I just miss the point. What's your use case?

Thanks,
Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/