Re: [PATCH] sched: Notify hrtimer users of switches to NOHZ mode

[Ingo Molnar]

* Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> On Tue, 2011-01-18 at 22:46 -0800, Stephen Boyd wrote:
> > When NOHZ=y and high res timers are disabled (via cmdline or
> > Kconfig) tick_nohz_switch_to_nohz() will notify the user about
> > switching into NOHZ mode. Nothing is printed for the case where
> > HIGH_RES_TIMERS=y. Fix this for the HIGH_RES_TIMERS=y case by
> > duplicating the printk from the low res NOHZ path in the high res
> > NOHZ path.
> > 
> > Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> > ---
> > 
> > This confused me since I was thinking 'dmesg | grep -i NOHZ' would
> > tell me if NOHZ was enabled, but if I have hrtimers there is
> > nothing. If we don't do this we should probably remove the original
> > printk.
> 
> I'm not quite sure we want _more_ dmesg chatter, [...]

Well, we used to have bugs in the past where the system locked up after changing the 
main hrtimer mode, so the messages are useful.

This patch completes the messages in that sense and makes them consistent. If we 
want to remove them altogether that would be another patch.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/