Re: [PATCH v5] input: tegra-kbc - Add tegra keyboard driver

From: Dmitry Torokhov
Date: Wed Jan 19 2011 - 00:23:38 EST


On Tue, Jan 18, 2011 at 07:28:29PM -0800, Rakesh Iyer wrote:
> Sorry for the late response as I was not working on it on Monday.
>
> The patch as is did not work. I am debugging this currently.

Sorry about that. If you describe the effects you are seeing I might try
to think where I messed up.

>
> Once I find a fix, can I resend all the driver code as one patch file?
> I will include your 2nd patch in it as well.

Sure.

>
> Secondly, the driver is a platform driver for Tegra platforms. The
> platform code needs some of the #defines to be present in kbc.h, so
> you will see some of the defines moved back to kbc.h from tegra-kbc.c
>

I only moved KBC_MAX_COL, KBC_MAX_ROW and KBC_MAX_KEY since they are
not needed in keymaps expressed via struct matrix_keypad_data. But if
they are needed for something else that's fine.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/