Re: [PATCH 3/3] trusted-keys: small cleanup

[Mimi Zohar]

On Tue, 2011-01-18 at 10:39 +0900, Tetsuo Handa wrote:
> Mimi Zohar wrote:
> > Change the existing '(!ret)' to '(ret < 0)', like the rest of the code?
> > It's not wrong, but ....
> 
> Something like this?

Actually, I was only asking for a one line change in the patch.

> >       va_end(argp);
> > -     ret = crypto_shash_final(&sdesc->shash, paramdigest);
> > +     if (!ret)
> > +             ret = crypto_shash_final(&sdesc->shash, paramdigest);
> >       if (!ret)

Change the second '(!ret)' here, the crypto_shash_file() return code
test, from '(!ret)' to '(ret < 0)', like the other crypto_shash_file()
tests.

Thanks!

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/