Re: [PATCH 0/2 v2] perf-kvm support for SVM

From: Roedel, Joerg
Date: Mon Jan 17 2011 - 06:52:03 EST


On Sun, Jan 16, 2011 at 10:38:11AM -0500, Avi Kivity wrote:
> On 01/16/2011 05:35 PM, Joerg Roedel wrote:
> > On Sun, Jan 16, 2011 at 12:49:41PM +0200, Avi Kivity wrote:
> > > On 01/14/2011 05:45 PM, Joerg Roedel wrote:
> >
> > >> here is the reworked version of the patch-set. Only patch 1/2 has
> > >> changed and now contains the real fix for the crashes that were seen and
> > >> has an updated log message.
> > >>
> > >
> > > Thanks, applied. 2.6.37 and earlier aren't affected, yes? So I'm
> > > queuing it for 2.6.38 only.
> >
> > I think the problem is there since KVM has lazy state switching. So the
> > fix in patch 1 should make it in all currently maintained stable-trees.
> >
>
> The problem is with load_gs_index(), yes? In 2.6.37 this is called
> before stgi(), so it's protected from nmi.

Ok, you are right :) So the fix is only necessary for 2.6.38.

Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/