Re: [RFC V10 3/7] drivers:media:radio: wl128x: FM Driver Common sources

[halli manjunatha]

Hi Hans and Mauro,

If there are no major comments for the V10 of FM V4L2 driver, is it
possible to take this driver (V10) to mainline?

Since the files are becoming big to be posted as patches and
maintaining it that way is a bit difficult. We can submit the patches
to mainline to fix minor comments and also to add newer features
(complete scan, stop seek) as patches once this driver makes its way
in to mainline.

Please let me know your views on this.

Thanks,
Manju


On Tue, Jan 11, 2011 at 6:12 PM, Raja Mani <rajambsc@xxxxxxxxx> wrote:
> balbi,
>
>  Agree , interrupt pkts could have handled in thread context . But in
> the current way , FM driver never create any additional task in the
> system
>  to handle FM interrupt. In fact, there is no task being created in
> this driver to handle FM RDS data, AF,etc.
>
>  This method is suitable for light weight system where we want to
> reduce number of thread in the system.
>
>  On Tue, Jan 11, 2011 at 4:54 PM, Felipe Balbi <balbi@xxxxxx> wrote:
>> Hi,
>>
>> On Tue, Jan 11, 2011 at 06:31:23AM -0500, manjunatha_halli@xxxxxx wrote:
>>> From: Manjunatha Halli <manjunatha_halli@xxxxxx>
>>>
>>> These are the sources for the common interfaces required by the
>>> FM V4L2 driver for TI WL127x and WL128x chips.
>>>
>>> These implement the FM channel-8 protocol communication with the
>>> chip. This makes use of the Shared Transport as its transport.
>>>
>>> Signed-off-by: Manjunatha Halli <manjunatha_halli@xxxxxx>
>>> Reviewed-by: Hans Verkuil <hverkuil@xxxxxxxxx>
>>
>> looks like this is implementing a "proprietary" (by that I mean: for
>> this driver only) IRQ API. Why aren't you using GENIRQ with threaded
>> IRQs support ?
>>
>> Core IRQ Subsystem would handle a lot of stuff for you.
>>
>> --
>> balbi
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
>
>
> --
> Regards,
> Raja.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Regards
Halli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/