[PATCH] staging: cs5535_gpio: check put_user() return code

From: Vasiliy Kulikov
Date: Mon Jan 17 2011 - 05:09:03 EST


put_user() may fail, if so return -EFAULT.

Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
---
Compile tested only.

drivers/staging/cs5535_gpio/cs5535_gpio.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/cs5535_gpio/cs5535_gpio.c b/drivers/staging/cs5535_gpio/cs5535_gpio.c
index 0cf1e5f..b25f9d1 100644
--- a/drivers/staging/cs5535_gpio/cs5535_gpio.c
+++ b/drivers/staging/cs5535_gpio/cs5535_gpio.c
@@ -146,7 +146,8 @@ static ssize_t cs5535_gpio_read(struct file *file, char __user *buf,

/* add a line-feed if there is room */
if ((i == ARRAY_SIZE(rm)) && (count < len)) {
- put_user('\n', buf + count);
+ if (put_user('\n', buf + count))
+ return -EFAULT;
count++;
}

--
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/