Re: [PATCH v2] spi: New driver for Altera SPI

[Thomas Chou]

On 01/17/2011 01:59 PM, Stephen Rothwell wrote:
> > +/*
> > + * struct altera_spi_platform_data - platform data of the Altera SPI
> > + * @interrupt:	use intrrupt driven data transfer.
> > + */
> > +struct altera_spi_platform_data {
> > +	int interrupt;
> > +};
>
> Is there some reason that this struct definition cannot just be placed
> in spi_altera.c and so save a whole extra file (and its inclusion)?

Hi Stephen,

It is needed for board configuration file to attach this platform data, 
which is used to choose between interrupt driven data transfer or 
polling method. The data transfer rate is usually faster for polling, as 
interrupt overhead is higher.

Best regards,
Thomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/