Re: [PATCH] param: add null statement to compiled-in module params

From: Rusty Russell
Date: Sun Jan 16 2011 - 18:46:43 EST


On Wed, 5 Jan 2011 10:57:04 pm Linus Walleij wrote:
> Add an unused struct declaration statement requiring a
> terminating semicolon to the compile-in case to provoke an
> error if __MODULE_INFO() is used without the terminating
> semicolon. Previously MODULE_ALIAS("foo") (no semicolon)
> compiled fine if MODULE was not selected.

I really prefer the other way; make everyone use a semicolon.

Let's look how many we're talking about... hmm, I'm having
trouble finding any!

Could you patch this the other way, to make MODULE_ALIAS w/o a
semicolon always an error?

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/