Re: [git pull] vfs pile 2 (automount work)

From: Joachim Eastwood
Date: Sun Jan 16 2011 - 17:05:54 EST


On 1/16/11, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Jan 16, 2011 at 10:15:31PM +0100, Joachim Eastwood wrote:
>> Hi,
>>
>> On 1/16/11, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>> > Al Viro (3):
>> > sanitize vfsmount refcounting changes
>>
>> f03c65993b98eeb909a4012ce7833c5857d74755 - sanitize vfsmount refcounting
>> changes
>>
>> Breaks my ARM !CONFIG_SMP compile
>>
>> CC fs/namespace.o
>> fs/namespace.c: In function 'commit_tree':
>> fs/namespace.c:629: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c: In function 'umount_tree':
>> fs/namespace.c:1192: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c: In function 'mnt_make_longterm':
>> fs/namespace.c:2246: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c: In function 'mnt_make_shortterm':
>> fs/namespace.c:2251: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c:2254: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c: In function 'dup_mnt_ns':
>> fs/namespace.c:2295: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c:2299: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c:2305: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>> fs/namespace.c: In function 'create_mnt_ns':
>> fs/namespace.c:2351: error: 'struct vfsmount' has no member named
>> 'mnt_longterm'
>
> Aaaaargh... Brown paperbag time - all testing was on SMP boxen ;-/ The fix
> follows. Linus, I've dropped that into for-linus in usual place
> (git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/), so if you
> prefer to pull it, it's there.
>
> commit 91ed228ab50daa7aca54faa8bf5208b97e3448b8
> Author: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Date: Sun Jan 16 16:32:11 2011 -0500
>
> mnt_longterm is there only on SMP
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Thanks,
The patch fixed it.

regards
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/