Re: Please revert nouveau.

From: Anca Emanuel
Date: Sun Jan 16 2011 - 14:05:51 EST


On Sun, Jan 16, 2011 at 8:56 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Jan 16, 2011 at 10:50 AM, Anca Emanuel <anca.emanuel@xxxxxxxxx> wrote:
>>
>> after
>> git revert dfe63bb0ad9810db13aab0058caba97866e0a681
>
> You are aware that that was already reverted yesterday? See commit 3632ef89.
>
>> and
>>
>> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
>> index 5c4f9b9..2aad663 100644
>> --- a/drivers/gpu/drm/drm_fb_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_helper.c
>> @@ -816,6 +816,7 @@ int drm_fb_helper_set_par(struct fb_info *info)
>>                        mutex_unlock(&dev->mode_config.mutex);
>>                        return ret;
>>                }
>> +               drm_fb_helper_fill_fix(info, fb_helper->fb->pitch,
>> fb_helper->fb->depth);
>>        }
>>        mutex_unlock(&dev->mode_config.mutex);
>>
>> I have an partial working sistem.
>
> What does "partial working system" even MEAN?
>
> Anca, stop emailing worthless crap. Tell what the problems are. And cc
> the right people rather than asking me personally to just "revert"
> without even saying what the problem is. And if you feel like they
> have been ignoring you, then I have a clue for you: I bet they have
> been frustrated by the same things I am frustrated by.
>
> IOW, do a nice proper bug-report. Do it to the right people. Include
> useful information, and remember that the developers DO NOT see the
> problem you have (if they did, they'd not have done the changes), so
> "doesn't work" or "the boot screen is not ok" is not something anybody
> is ever going to find useful.
>
>         Linus
>

Linus, I am a beginner, I will try to be more useful in the future.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/