Re: [PATCH] Trusted and Encrypted Keys: fix up TSS_rawhmac() sowealways kfree() and remember to call va_end()

[Jesper Juhl]

On Fri, 14 Jan 2011, Tetsuo Handa wrote:

> Tetsuo Handa wrote:
> > Please wait. That patch is incorrect. I'm making patch now.
> I'm doing "git pull" now. Using 2.6.37-git11 instead.
> 
> James Morris wrote:
> > It's queued in my for-linus branch, waiting to see what happens with 
> > http://marc.info/?l=linux-security-module&m=129494927918805&w=3
> 
> I think above patch is incorrect because va_end() might be called without
> va_start(). C says va_start() without va_end() causes undefined behavior.
> I think va_end() without va_start() causes undefined behavior as well.
> 

I agree. Your patches are better. Thanks.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/