Re: [PATCH 1/2] drm: fixup headers_check

[Felipe Balbi]

On Sun, Jan 16, 2011 at 11:07:32AM +0000, Chris Wilson wrote:
> On Sun, 16 Jan 2011 12:46:22 +0200, Felipe Balbi <balbi@xxxxxx> wrote:
> > Drop the following headers_check errors:
> > /linux-2.6/usr/include/drm/drm_mode.h:85: found
> > __[us]{8,16,32,64} type without #include <linux/types.h>
> > /linux-2.6/usr/include/drm/i915_drm.h:120: found
> > __[us]{8,16,32,64} type without #include <linux/types.h>
> > /linux-2.6/usr/include/drm/mga_drm.h:260: found
> > __[us]{8,16,32,64} type without #include <linux/types.h>
> > /linux-2.6/usr/include/drm/radeon_drm.h:758: found
> > __[us]{8,16,32,64} type without #include <linux/types.h>
> > /linux-2.6/usr/include/drm/via_drm.h:117: found
> > __[us]{8,16,32,64} type without #include <linux/types.h>
> > 
> > Cc: David Airlie <airlied@xxxxxxxx>
> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> >  include/drm/drm_mode.h   |    2 ++
> >  include/drm/i915_drm.h   |    1 +
> >  include/drm/mga_drm.h    |    1 +
> >  include/drm/radeon_drm.h |    1 +
> >  include/drm/via_drm.h    |    1 +
> >  5 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
> > index 0fc7397..1678d7b 100644
> > --- a/include/drm/drm_mode.h
> > +++ b/include/drm/drm_mode.h
> > @@ -27,6 +27,8 @@
> >  #ifndef _DRM_MODE_H
> >  #define _DRM_MODE_H
> >  
> > +#include <linux/types.h>
> > +
> 
> Would
> 
> #if 0
> #include <linux/types.h> /* silence make header_check */
> #endif
> 
> be an acceptable compromise?

Why would you want to do that ? I truly have those types in use.
headers_check seems to be reporting correctly.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/