Re: [RFC PATCH 2/2] power_supply: Add new LED trigger charging-blink-solid-full

[Vasily Khoruzhick]

On Friday 14 January 2011 18:18:51 Anton Vorontsov wrote:

> Strange, I got neither 0/2 nor 1/2.

Hmm, patches are definitely on ML, here's link to 1st patch on patchwork:
https://patchwork.kernel.org/patch/464481/

However, if you want, I can forward copy of 0/2 and 1/2 to you directly, but 
check your 'spam' folder first ;)

> Anyway, I'm fine with this particular patch, but to take 1/2 via
> battery-2.6.git I need Richard's Acked-by tag.

Ok

> > +		led_trigger_blink(psy->charging_blink_full_solid_trig,
> > +			&delay_on, &delay_off);
> 
> I think it's better to allow passing NULL to led_trigger_blink()
> and thus avoid delay_{on,off} dummy variables.

It mimics led_blink_set function, and I prefer to keep it this way (just to 
keep consistency), or change led_blink_set behavior.

Regards
Vasily
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/