Re: [PATCH] fs/eventpoll.c: fix compilation warning

[viresh kumar]

On 01/14/2011 03:03 PM, Jack Stone wrote:
>> >-	long slack;
>> >+	long slack = 0;
>> > 	wait_queue_t wait;
>> > 	struct timespec end_time;
>> > 	ktime_t expires, *to = NULL;
> I don't think this is the correct fix. This function is fine unless timeout is negative.
> 
> If a negative timeout is possible then this function will create timer far in the future.
>I'll leave it up to the maintainer how to solve that one. The two solutions I can see are making
>timeout unsigned or extending the bottom case of the if to <=0.
> 
> Either way we should use uninitalized_var() rather than setting it to zero.

Using uninitialized var gives compilation warning, How should we fix that.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/