Re: [PATCH] net: add Faraday FTMAC100 10/100 Ethernet driver

[Po-Yu Chuang]

Dear Joe,

On Fri, Jan 14, 2011 at 7:05 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Thu, 2011-01-13 at 19:49 +0800, Po-Yu Chuang wrote:
>> From: Po-Yu Chuang <ratbert@xxxxxxxxxxxxxxxx>
> []
>> + Â Â if (is_zero_ether_addr(netdev->dev_addr)) {
>> + Â Â Â Â Â Â random_ether_addr(netdev->dev_addr);
>> + Â Â Â Â Â Â dev_info(&netdev->dev, "generated random MAC address "
>> + Â Â Â Â Â Â Â Â Â Â "%.2x:%.2x:%.2x:%.2x:%.2x:%.2x.\n",
>> + Â Â Â Â Â Â Â Â Â Â netdev->dev_addr[0], netdev->dev_addr[1],
>> + Â Â Â Â Â Â Â Â Â Â netdev->dev_addr[2], netdev->dev_addr[3],
>> + Â Â Â Â Â Â Â Â Â Â netdev->dev_addr[4], netdev->dev_addr[5]);
>
> Sorry, one other thing.
> There are kernel specific printf extensions for pointer types.
> (look at lib/vsprintf.c) ÂThere's one for mac addresses: "%pM".
> This could be done as:
>
> Â Â Â Â Â Â Â Ânetdev_info(netdev, "Generated random MAC address: %pM\n",
> Â Â Â Â Â Â Â Â Â Â Â Â Â Ânetdev->dev_addr);

Wow, this is pretty beautiful. Thanks.

best regards,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/