Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[Andi Kleen]

On Fri, Jan 14, 2011 at 12:55:03AM +0100, Robert Richter wrote:
> On 13.01.11 17:38:11, Shawn Bohrer wrote:
> > Added missing core i7 models found in "Intel 64 and IA-32 Architectures
> > Software Developer's Manual Volume 3B: System Programming Guide",
> > Table B-1.  Tested with oprofile 0.9.6 on a:
> > 
> > model      : 44
> > model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz
> > 
> > Signed-off-by: Shawn Bohrer <sbohrer@xxxxxxxxxxxxxxx>
> 
> Andi,
> 
> please ACK.

NACK -- first it's wrong because that's a westmere and westmere
has a different event list. And the new way is to fall back to arch-perfmon
and handle the CPUID in user space. This has been already implemented.
So the fix is to upgrade user space.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/