Re: [PATCH] adding gpmc configuration functions, west bridgerelated

[Greg KH]

On Thu, Jan 13, 2011 at 03:23:14PM -0800, Sutharsan Ramamoorthy wrote:
> This patch implements gpmc configuration functions needed by westbridge
> device controller driver in staging tree. These functions currently 
> implemented in staging tree. This patch is part of the effort to bring 
> westbridge device controller driver out of staging tree.
> 
> Signed-off by: Sutharsan Ramamoorthy <sutharsan.ramamoorthy@xxxxxxxxx>

Close, but not quite.

Why remove your cypress.com email address here?  That's who really is
"signing off" on this patch, right?

Also, please note my previous comments about "lots more needs to be done
to the driver before this can even start to move out of the staging
tree".  Moving these functions should be one of the _last_ things that
happens, not the first.

Please work on cleaning up the code in the drivers/staging/westbridge/
directory first.  When that is all done, _then_ we can start moving it
out.

Ok?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/