Re: [PATCH] acpi/pm: If failed at validating ACPI PM timer, inhibitfuture reads.

[Thomas Gleixner]

On Thu, 13 Jan 2011, Konrad Rzeszutek Wilk wrote:

> tgl, John,
> 
> Should I push this to Linus or are you guys going to push
> this patch during this merge window?

Wait a moment. This patch is fresh of the press and not that urgent,
really.
 
>     I've traced it down to the fact that when we boot under Xen we do
>     not have the HPET enabled nor the ACPI PM timer setup. The

Crap. If Xen would not have setup the pm timer then it would not even
reach the consistency check. It would simply bail out via

        if (!pmtmr_ioport)
                return -ENODEV;

and the whole misery would not have happened at all. Though it's a
Good Thing that Xen is so screwed as it points to a real flaw which
might happen on real hardware as well. See below

>     hpet_enable() is never called (b/c xen_time_init is called), and
>     for calibration of tsc_khz (calibrate_tsc == xen_tsc_khz) we
>     get a valid value.
>     
>     So 'tsc_read_refs' tries to read the ACPI PM timer (acpi_pm_read_early),
>     however that is disabled under Xen:
>     
>     [    1.099272] calling  init_acpi_pm_clocksource+0x0/0xdc @ 1
>     [    1.140186] PM-Timer failed consistency check  (0x0xffffff) - aborting.
>     
>     So the tsc_calibrate_check gets called, it can't do HPET, and reading
>     from ACPI PM timer results in getting 0xffffff.. .. and
>     (0xffff..-0xffff..)/some other value results in div_zero.

Nonsense. 0/(some other value) does not result in a divide by zero
except "some other value" is zero.

>     There is a check in 'tsc_refine_calibration_work' for invalid
>     values:
>     
>        /* hpet or pmtimer available ? */
>              if (!hpet && !ref_start && !ref_stop)
>                       goto out;
>     
>     But since ref_start and ref_stop have 0xffffff it does not trigger.
>
>     This little fix makes the read to be 0 and the check triggers.

First of all the patch disables the pm_timer completely, which happens
to results in a 0 read as a side effect. But the main point of this
fix is to disable pmtimer in case of failure in the init function
completely.

Further there are several error conditions in this init function and
we really need to disable pmtimer for all of them not just for the
case you encountered.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/