Re: [PATCH] drm/i915/execbuffer: Clear domains before beginning reloc processing

[Alessandro Suardi]

On Thu, Jan 13, 2011 at 5:10 PM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 13 Jan 2011 07:54:59 -0800, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>> On Thu, Jan 13, 2011 at 3:07 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
>> > After reordering the sequence of relocating objects, commit 6fe4f1404,
>> > we can no longer rely on seeing all reloc targets prior to performing
>> > the relocation. So we need to clear the relocation domains earlier.
>>
>> Yup, this one (together with the previous fix) seems to get rid of all
>> the artifacts.

Just to add that this patch also fixes my gnome top and bottom panels
 on F14 where mouseover on the icons caused them to disappear and
 reappear, partly or entirely; in detail,

 2.6.37-git7 => ok
 2.6.37-git8 => ok
 2.6.37-git9 => bad (mouseover on panels has icons disappearing/reappearing)
 2.6.37-git9 + patch => ok

>> Should I just apply them as patches, or do you have a git branch to pull from?
>
> They will be in drm-intel-fixes. There have been a couple of other patches,
> for the compiler warning, the typo that Indan spotted and for modparam to
> workaround the U160, so I'll send the pull request it via Dave.
> -Chris
>
> $ git shortlog linus..upstream/drm-intel-fixes
> Chris Wilson (5):
>      drm/i915/debugfs: Correct format after changing type of err object 'size'
>      drm/i915: Add a module option to override the use of SSC
>      drm/i915: Fix error handler to capture the first batch after the seqno
>      drm/i915/execbuffer: Reorder relocations to match new object order
>      drm/i915/execbuffer: Clear domains before beginning reloc processing
>
> Indan Zupancic (1):
>      drm/i915/panel: The backlight is enabled if the current value is non-zero
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
--alessandro

 "There's always a siren singing you to shipwreck"

   (Radiohead, "There There")
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/