Re: [PATCH] drm/i915/execbuffer: Reorder relocations to match newobject order

[Linus Torvalds]

On Wed, Jan 12, 2011 at 4:48 PM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 12 Jan 2011 16:27:46 -0800, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> I think you're still missing some case.
>>
>> This improves the video case a lot - I can't see any artifacts there -
>> but I still get occasional corruption when moving between the "share"
>> and "rate" buttons, and they end up drawing incorrectly.
>
> Now we're probably drifting into other bug territory... ;-)
>
> I'll look again in the morning. Usually running the conformance test
> suites in parallel is enough to exercise the worst-case behaviour.

I'm pretty dang sure it's still the same bug.

I went back to the revert, and tried very hard, but I cannot reproduce
even a whiff of the corruption with the revert. No corruption
what-so-ever.

With your patch, the corruption is _less_, but it's absolutely there.
So the re-ordering of the object list is doing something else too.

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/