Re: [PATCH] sound: constify functions in ac97

[Takashi Iwai]

At Wed, 12 Jan 2011 14:44:07 +0200,
Alexey Dobriyan wrote:
> 
> On Wed, Jan 12, 2011 at 1:03 PM, Hanno BÃck <hanno@xxxxxxxxx> wrote:
> > Âstruct snd_ac97_build_ops {
> > - Â Â Â int (*build_3d) (struct snd_ac97 *ac97);
> > - Â Â Â int (*build_specific) (struct snd_ac97 *ac97);
> > - Â Â Â int (*build_spdif) (struct snd_ac97 *ac97);
> > - Â Â Â int (*build_post_spdif) (struct snd_ac97 *ac97);
> > + Â Â Â int (* const build_3d) (struct snd_ac97 *ac97);
> > + Â Â Â int (* const build_specific) (struct snd_ac97 *ac97);
> > + Â Â Â int (* const build_spdif) (struct snd_ac97 *ac97);
> > + Â Â Â int (* const build_post_spdif) (struct snd_ac97 *ac97);
> > Â#ifdef CONFIG_PM
> > - Â Â Â void (*suspend) (struct snd_ac97 *ac97);
> > - Â Â Â void (*resume) (struct snd_ac97 *ac97);
> > + Â Â Â void (* const suspend) (struct snd_ac97 *ac97);
> > + Â Â Â void (* const resume) (struct snd_ac97 *ac97);
> > Â#endif
> > - Â Â Â void (*update_jacks) (struct snd_ac97 *ac97); Â /* for jack-sharing */
> > + Â Â Â /* for jack-sharing */
> > + Â Â Â void (* const update_jacks) (struct snd_ac97 *ac97);
> 
> Can we please not do this.
> 
> You made whole ops structure RO, this is enough.

Yes.  Hanno, could you fix and resubmit?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/