Re: [PATCH v2] hid-multitouch: changes from the review process

[Henrik Rydberg]

On Tue, Jan 11, 2011 at 06:38:24PM +0100, Benjamin Tissoires wrote:
> On Tue, Jan 11, 2011 at 6:35 PM, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote:
> > On Tue, Jan 11, 2011 at 04:45:54PM +0100, Benjamin Tissoires wrote:
> >> * amended Kconfig (PixCir and Hanvon are the same panel but with
> >>   different name)
> >> * insert field name in mt_class and retrieving it in mt_probe
> >> * add 2 quirks: MT_QUIRK_VALID_IS_INRANGE, MT_QUIRK_VALID_IS_CONFIDENCE,
> >>   in order to find the field "valid"
> >> * inlined slot_is_contactid and slot_is_contact_number
> >> * cosmetics changes (tabs and comments)
> >> * do not send unnecessary properties once the touch is up
> >>
> >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxx>
> >
> > There are some syntactic suboptimalities in the resulting file that
> > perhaps could be fixed, but content-wise, I have nothing further. So,
> > given that it actually works,
> >
> > Acked-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> >
> > Thank you very much for your work, Benjamin.
> 
> Thanks for the review Henrik,

Regarding the quanta patches you have pending, IFAICT the 0408:3001
device is not properly supported currently, so perhaps that one could
be added to the list, too.

Cheers,
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/