Re: [PATCH] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMInotification type support

[Huang Ying]

On Wed, 2011-01-12 at 12:55 +0800, Len Brown wrote:
> >        if (error_block_length > GHES_ESTATUS_MAX_SIZE) {
> >-               pr_warning(FW_WARN GHES_PFX
> >-                          "Error status block length is too long: %u for "
> >-                          "generic hardware error source: %d.\n",
> >+               pr_warning(
> >+FW_WARN GHES_PFX "Error status block length is too long: %u for \n"
> >+"generic hardware error source: %d.\n",
> >                           error_block_length, generic->header.source_id);
> >                error_block_length = GHES_ESTATUS_MAX_SIZE;
> 
> Hi Ying,
> 
> I assume that you are tweaking these pr_warning() lines
> to beautify the output, but as far as source
> code readability, I liked the previous syntax better.
> 
> Although maintainer's opinions vary, I generally do not
> strictly enforce the 80 column rule for printk strings.
> Ie. I think that code readability with good whitespace
> indentation plus printk string grep-ability are more
> important than strictly fitting within 80-columns.

OK. I will keep the previous format.

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/