Re: [PATCH] hpsa: do not re-order commands in internal queues

[Christoph Hellwig]

> -static inline void addQ(struct hlist_head *list, struct CommandList *c)
> +static inline void addQ(struct list_head *list, struct CommandList *c)
>  {
> -	hlist_add_head(&c->list, list);
> +	list_add_tail(&c->list, list);
>  }
>  
>  static inline u32 next_command(struct ctlr_info *h)
> @@ -366,9 +366,9 @@ static void enqueue_cmd_and_start_io(struct ctlr_info *h,
>  
>  static inline void removeQ(struct CommandList *c)
>  {
> -	if (WARN_ON(hlist_unhashed(&c->list)))
> +	if (WARN_ON(list_empty(&c->list)))
>  		return;
> -	hlist_del_init(&c->list);
> +	list_del_init(&c->list);

Any reason to keep these helpers?  They don't really help
clarifying the code, and iterations also use the list directly, thus
breaking the abstraction.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/