Re: [PATCH 04/16] x86: Replace cpu_2_logical_apicid[] with earlypercpu variable

[Tejun Heo]

On Mon, Jan 10, 2011 at 07:48:41PM -0800, David Rientjes wrote:
> On Thu, 30 Dec 2010, Tejun Heo wrote:
> 
> > Unlike x86_64, on x86_32, the mapping from cpu to logical apicid may
> > vary depending on apic in use.  cpu_2_logical_apicid[] array is used
> > for this mapping.  Replace it with early percpu variable
> > x86_cpu_to_logical_apicid to make it better aligned with other
> > mappings.
> > 
> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> 
> The apicid's are now stored as int's as opposed to u8, even though the max 
> is 256.  Is that for extendability or for better alignment?  If not, I 
> think it would be better to keep the old type.

I don't know.  Yeah, it's x86_32 only so it can be u8 but other IDs
are shared with x86_64 and should be int.  I think it's less confusing
to simply use int.  It's not like the extra overhead is gonna be
noticeable or anything.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/