Re: [RFC V10 3/7] drivers:media:radio: wl128x: FM Driver Commonsources

[Felipe Balbi]

Hi,

On Tue, Jan 11, 2011 at 06:31:23AM -0500, manjunatha_halli@xxxxxx wrote:
> From: Manjunatha Halli <manjunatha_halli@xxxxxx>
> 
> These are the sources for the common interfaces required by the
> FM V4L2 driver for TI WL127x and WL128x chips.
> 
> These implement the FM channel-8 protocol communication with the
> chip. This makes use of the Shared Transport as its transport.
> 
> Signed-off-by: Manjunatha Halli <manjunatha_halli@xxxxxx>
> Reviewed-by: Hans Verkuil <hverkuil@xxxxxxxxx>

looks like this is implementing a "proprietary" (by that I mean: for
this driver only) IRQ API. Why aren't you using GENIRQ with threaded
IRQs support ?

Core IRQ Subsystem would handle a lot of stuff for you.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/