Re: [PATCH -v3 0/4] x86, usb, pci: Disable usb legacy support early

From: Greg KH
Date: Mon Jan 10 2011 - 22:40:08 EST


On Mon, Jan 10, 2011 at 05:25:56PM -0800, Yinghai Lu wrote:
> On 01/10/2011 05:07 PM, Greg KH wrote:
> > On Mon, Jan 10, 2011 at 04:49:02PM -0800, Yinghai Lu wrote:
> >>
> >> Move quirks for usb handoff early for x86.
> >>
> >> So we can get stable result when trying to calibrate apic timer with pm-timer.
> >
> > I still fail to understand _why_ you are making these changes.
> >
> > Exactly what problem do you currently have, on what hardware, that this
> > patch set solves?
> 1. remove the warning

What warning?

> 2. apic timer clockevent will be more accurate instead of use PM to calibrate it.
> on Intel newer system with 128 logical cpus or more.

Is that a problem?

> guess SMI handler for USB legacy support may need more time coordinate between those cpus.

Are you sure?

And again, please post this in your messages, otherwise we are just
guessing, and if we have to guess, we will error on the "ignore the
patch" side.

You need to sell us on why we should accept these patches, so far, I see
no real reason at all for them.

good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/