Re: [PATCH 3/4] memstick: add support for legacy memorysticks

[Alex Dubov]

> +
> +    case 2: /* send INT request */
> +        if
> (msb_read_int_reg(msb, -1))
> +           
> break;
> +        msb->state++;
> +
> +    case 3: /* get result of the INT

I still think it would look nicer if you could name your state with explicit
names and use "next_state()" or something to move on, instead of just
incrementing it.
Otherwise, I have no principal objections.



      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/