Re: [PATCH 1/2] Add a common struct clk

From: Jeremy Kerr
Date: Mon Jan 10 2011 - 19:54:38 EST


Hi Russell,

> Unless the locking problems can be resolved, the patches aren't ready.
>
> From what I've seen there's still quite a problem with what kind of
> lock to use in the clock - mutex or spinlock.

Yes, the clock driver may either use a spinlock or mutex.

However, this exactly the same as the current clock code, my patches do not
alter what we currently have.

I do agree that we should define some specific semantics for the clock API
with regards to sleeping, and I'll start a new thread about that. But we
should definitely separate that issue from the problem of having multiple
definitions for struct clk, which is what these patches address.

Cheers,


Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/