Re: [PATCH] USB SD Host Controller: Including usb.h once is enough

[Chris Ball]

Hi Jesper,

On Mon, Jan 10, 2011 at 10:19:11PM +0100, Jesper Juhl wrote:
> > On Mon, Jan 10, 2011 at 09:56:08PM +0100, Jesper Juhl wrote:
> > > 
> > > Including usb.h once is enough in drivers/mmc/host/ushc.c
> > > This removes the duplicate.
> > > 
> > > 
> > > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Thanks, queued for .38.

> No reason.
> Didn't think of it as "newlines in the commit-msg", just as newlines 
> providing a nice seperation between patch description and the patch 
> itself. It never occurred to me that anyone would actually copy those 
> blank lines into an actual commit message.

I don't copy anything into the commit message -- I like to run git-am
on the patch mail in my mailbox directly.  In this case, git-am seems
to have removed the extra newlines itself, which was nice of it, but in
general please send mail such that from the start of the body of the
mail up to the "---" separator will become the commit message.  Thanks!

-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/