Re: [GIT PULL] SLAB changes for v2.6.38

From: Linus Torvalds
Date: Mon Jan 10 2011 - 11:44:29 EST


On Sun, Jan 9, 2011 at 1:13 AM, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
>
> It's been rather quiet for slab allocators this merge cycle. There's only
> few cleanups here. The bug fixes were merged in v2.6.37 already. As they
> were cherry-picked from this branch, they show up in the pull request
> (what's up with that btw).

For the "what's up with that btw" department:

A cherry-pick really is nothing but "apply the same patch as a
different commit".

So there is no way to say "this is already there" - because it really
isn't. It's a totally different thing. In fact, it would be very wrong
to filter them out, both from a fundamental design standpoint, but
also from a usability/reliability standpoint: cherry-picks are by no
means guaranteed to be identical to the source - like any "re-apply
the patch in another place" model, the end result is not at all
guaranteed to be semantically identical simply due to different bases:
the patches may not even be identical, and even if they are, the
results of the code may depend on what else is going on.

So don't think of cherry-picks as "the same commit". It's not, and it
never will be. It's a totally separate commit, they just share some
superficial commonalities.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/