Re: [PATCH 1/3] pci, usb: Seperate usb handoff func to another file

From: Yinghai Lu
Date: Mon Jan 10 2011 - 02:04:26 EST


On 01/09/2011 01:09 PM, Benjamin Herrenschmidt wrote:
> acceptable ?
>
> I think if you want to make the handoff happen -that- early, you have
> basically two options. One is to move it all to arch code, and the other
> one is to create early-boot "fake" struct pci_dev & bus that have the
> config callbacks implemented pointing to the early stuff. You can do
> that entirely within your arch code, and avoids most of the grossness
> above in the generic places.

good idea, will make one get_early_pci_dev() for x86 as dummy device.

>
> It would avoid that turd too:
>
>> +#include "usb_handoff.c"

may still need that to avoid some MMIO bar finding and remapping etc.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/