Re: [PATCH 1/2] watchdog: Add support for sp5100 chipset TCO

From: Wim Van Sebroeck
Date: Sun Jan 09 2011 - 04:33:30 EST


Hi Mike,

> The cleanups above seem fine to me. What did you mean by "Change
> reboot_notifier by a platform shutdown" though? I see that you
> removed the reboot_notifier, which is fine for our purposes. Was this
> a suggestion to have this stuff get called from platform code if
> needed? Am I missing something?

The platform_driver struct has a shutdown operation which does the same
as the reboot_notifier. Since the code is smaller and since the binary is
smaller we prefer to use the shutdown operation. So I removed the
reboot_notifier and added the shutdown operation.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/