Re: [058/152] tcp: protect sysctl_tcp_cookie_size reads

[William Allen Simpson]

This is a multi-part message in MIME format.On 1/7/11 8:36 AM, Pekka Enberg wrote:
> On Fri, Jan 7, 2011 at 3:05 PM, William Allen Simpson
> <william.allen.simpson@xxxxxxxxx>  wrote:
> > My instructors would have flunked me for not including braces around
> > multi-line sequences; it was one of the great no-no's of the '70s.  Perhaps
> > that's not the case anymore with modern colorful visual syntax checkers?
>
> That's because your instructors hadn't read Documentation/CodingStyle
> which didn't appear until the '90s.
Hi, Pekka.

OTOH, I *have* read Documentation/CodingStyle a cople year back, and then
re-checked it again today....  Out of curiosity, as I haven't done a Linux
patch in many months, I cloned linux-2.6 and checked out v2.6.36-rc8 (I don't
know where 2.6.36-stable is kept).

Note this patch is cleaner and more readable; lines that are changed have
one-to-one correspondence.

Eric was *not* *truthful* saying there were "checkpatch.pl errors/warnings" in
my code.

===

scripts/checkpatch.pl ~/sysctl_tcp_cookie_size-read-once.patch
total: 0 errors, 0 warnings, 36 lines checked

/home/test/sysctl_tcp_cookie_size-read-once.patch has no obvious style
problems and is ready for submission.