Re: [patch 2/3] add new macros to make percpu readmostly sectioncorrectly align

From: Tejun Heo
Date: Tue Dec 28 2010 - 06:13:52 EST


Hello,

On Tue, Dec 28, 2010 at 08:26:57AM +0800, Shaohua Li wrote:
> Subject: make readmostly section correctly align
>
> readmostly section should end at cache line aligned address, otherwise the last
> several data might share cachline with other data and make the readmostly data
> still have cache bounce.
> For example, in ia64, secpath_cachep is the last readmostly data, and it shares
> cacheline with init_uts_ns.
> a000000100e80480 d secpath_cachep
> a000000100e80488 D init_uts_ns
>
> Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>

Yeap, this looks good to me.

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

I can route this through percpu tree but think -mm is the better fit.
Andrew, can you please take this one?

Thank you.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/