Re: [PATCH 3/3] compat: copy missing fields in compat_statfs64 to user

From: Christoph Hellwig
Date: Mon Dec 27 2010 - 10:36:23 EST


On Mon, Dec 27, 2010 at 01:41:54AM +0900, Namhyung Kim wrote:
> f_flags and f_spare fields were not copied to userspace when
> compat_sys_[f]statfs64 called.
>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> ---
> It seems struct compat_statfs lacks the f_flags field in it but I'm not
> sure whether it is intended or not. Is it useful if I make a patch for
> it too?

Looks good. We discussed this a while back before it fell under the
table again.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/