Re: [RFC -v9 4/4] net, rds, Replace xlist in net/rds/xlist.h withllist

[Huang Ying]

Hi, 
On Thu, 2010-12-23 at 15:05 +0800, Valdis.Kletnieks@xxxxxx wrote:
> On Thu, 23 Dec 2010 13:43:23 +0800, Huang Ying said:
> > The functionality of xlist and llist is almost same.  This patch
> > replace xlist with llist to avoid code duplication.
> 
> >  /*
> > - * this takes a list head of mrs and turns it into an xlist of clusters.
> > - * each cluster has an xlist of MR_CLUSTER_SIZE mrs that are ready for
> > - * reuse.
> > + * this takes a list head of mrs and turns it into linked llist nodes.
> >   */
> 
> This comment change loses a lot of information.  The original 3 lines
> tells me a lot about what the data structure is and what it's used for,
> the replacement is a 'b +=5; /* add 5 to b */' type of comment.

Sorry, maybe I misunderstand the comments and code.  From comments I
imagine the result is a two-dimension lock-less list, but from the code
I only find an one-dimension lock-less list.  Is it?

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/