Re: [RFC v2 6/8] TILER-DMM: Geometry and view manipulationfunctions

[Greg KH]

On Tue, Nov 30, 2010 at 01:58:57PM -0600, David Sin wrote:
> From: Lajos Molnar <molnar@xxxxxx>
> 
> This patch contains information on TILER geometry, as well as
> tiler_view_t object manipulation functions.
> 
> It also contains an internal TILER header file to share geometric
> information with other TILER files.
> 
> Signed-off-by: Lajos Molnar <molnar@xxxxxx>
> Signed-off-by: David Sin <davidsin@xxxxxx>
> ---
>  drivers/misc/tiler/_tiler.h     |   48 +++++

Ick, no, just name it "tiler.h" please.  There should not be any need to
put _ in front of a .h file.

> +u32 tiler_bpp(const struct tiler_block_t *b)
> +{
> +	enum tiler_fmt fmt = tiler_fmt(b->phys);
> +	BUG_ON(fmt == TILFMT_INVALID || fmt == TILFMT_PAGE);

Don't cause the kernel to crash within a driver for no good reason like
this.  Please fix these to WARN_ON if it's really something that can
happen.

If not, then just remove it.

> +
> +	return geom[fmt].bpp;
> +}
> +EXPORT_SYMBOL(tiler_bpp);

EXPORT_SYMBOL_GPL() perhaps for all of these?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/