Re: [PATCH] cs5535-mfd: fix warning on x86-64

From: Andres Salomon
Date: Tue Nov 30 2010 - 16:44:18 EST


On Tue, 30 Nov 2010 10:22:57 -0800
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> On Mon, 29 Nov 2010 20:44:10 -0800 Andres Salomon wrote:
>
> > On Mon, 29 Nov 2010 11:52:57 +1100
> > Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > > Hi Samuel,
> > >
> > > After merging the mfd tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > drivers/mfd/cs5535-mfd.c: In function 'cs5535_mfd_probe':
> > > drivers/mfd/cs5535-mfd.c:106: warning: format '%d' expects type
> > > 'int', but argument 3 has type 'long unsigned int'
> > >
> >
> > Ick, ARRAY_SIZE is unsigned int on x86, unsigned long on x86-64.
> > The patch below fixes this.
> >
>
> No, it's a sizeof(), so it should be printed with %zd.
> That works on x86_64 or i386.
>

Thanks Randy. I'll provide a new patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/