Re: [PATCH v3 2/3] KVM: MMU: fix accessed bit set on prefault path

From: Xiao Guangrong
Date: Tue Nov 30 2010 - 11:48:00 EST


On 11/30/2010 09:29 PM, Gleb Natapov wrote:

>> + if (!shadow_accessed_mask)
>> + return;
>> +
> I don't get this. As far as I can see VMX inits shadow_accessed_mask to
> be zero if ept is enabled. This line here means that we never prefault with ept
> enabled. It is opposite from what it should be.
>

Since it's no accessed bit on EPT, it's no way to distinguish between actually
accessed translations and prefault.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/