Re: [PATCH] headers_check: better search for functions in headers

[Randy Dunlap]

On Tue, 30 Nov 2010 18:21:59 +0200 Alexander Shishkin wrote:

> Some headers don't bother with "extern" in function prototypes,
> which results in said prototypes being unnoticed and exported
> to userland.
> 
> This patch slightly improves detection of such cases by checking
> for C type names as well in the beginning of a line.
> 
> Signed-off-by: Alexander Shishkin <virtuoso@xxxxxxxxx>
> CC: Stephen Hemminger <shemminger@xxxxxxxxxx>
> CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> CC: Michal Marek <mmarek@xxxxxxx>
> CC: WANG Cong <amwang@xxxxxxxxxx>
> CC: linux-kernel@xxxxxxxxxxxxxxx
> ---
>  scripts/headers_check.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
> index 50d6cfd..e0e25a1 100644
> --- a/scripts/headers_check.pl
> +++ b/scripts/headers_check.pl
> @@ -64,7 +64,7 @@ sub check_include
>  
>  sub check_declarations
>  {
> -	if ($line =~m/^\s*extern\b/) {
> +	if ($line =~m/^(\s*extern|unsigned|char|short|int|long|void)\b/) {
>  		printf STDERR "$filename:$lineno: " .
>  		              "userspace cannot call function or variable " .

s/call/reference/ ?

>  		              "defined in the kernel\n";
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/