Re: [PATCH] mm: make ioremap_prot() take a pgprot.

From: Paul Mundt
Date: Tue Nov 30 2010 - 01:00:24 EST


On Tue, Nov 30, 2010 at 02:48:36PM +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2010-11-03 at 05:31 +0900, Paul Mundt wrote:
> > The current definition of ioremap_prot() takes an unsigned long for the
> > page flags and then converts to/from a pgprot as necessary. This is
> > unfortunately not sufficient for the SH-X2 TLB case which has a 64-bit
> > pgprot and a 32-bit unsigned long.
> >
> > An inspection of the tree shows that tile and cris also have their
> > own equivalent routines that are using the pgprot_t but do not set
> > HAVE_IOREMAP_PROT, both of which could trivially be adapted.
> >
> > After cris/tile are updated there would also be enough critical mass to
> > move the powerpc devm_ioremap_prot() in to the generic lib/devres.c.
> >
> > Signed-off-by: Paul Mundt <lethal@xxxxxxxxxxxx>
>
> Finally got to this :-)
>
> Looks good to me, compile test in progress and ... it passes.
>
> Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

Thanks. The -tip people didn't bite, so hopefully this can be picked up
for -mm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/