Re: [PATCH] Repalce strncmp by memcmp

From: Pavel Vasilyev
Date: Mon Nov 29 2010 - 17:49:51 EST


On 30.11.2010 01:26, Steven Rostedt wrote:
> On Mon, 2010-11-29 at 17:18 -0500, Steven Rostedt wrote:
>
>> Um, do you realize that the kernel does not always use the same memcmp
>> as gcc.
>>
> Note, I'm not against the change, because in 99% of the cases, memcmp()
> can and will be faster, and we don't need to worry about these strange
> cases.
>
> What I'm against is a blind s/strncmp/memcmp/ of the kernel, because it
> may have side effects that you may not have thought of.
>
Then we have to hang a large banner that is visible to all developers.
"Change wherever possible strncmp to memcmp," :)

--

Pavel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/