Re: [PATCH 53 of 66] add numa awareness to hugepage allocations

[Andrea Arcangeli]

On Mon, Nov 29, 2010 at 02:38:01PM +0900, Daisuke Nishimura wrote:
> I think this should be:
> 
> 	if (unlikely(mem_cgroup_newpage_charge(new_page, mm, GFP_KERNEL))) {
> #ifdef CONFIG_NUMA
> 		put_page(new_page);
> #endif
> 		goto out;
> 	}

Hmm no, the change you suggest would generate memory corruption with
use after free.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/