Re: [patch 4/7] fs: preserve inode dirty bits on failed metadatawriteback

From: Christoph Hellwig
Date: Mon Nov 29 2010 - 09:59:42 EST


On Wed, Nov 24, 2010 at 01:06:14AM +1100, npiggin@xxxxxxxxx wrote:
> Otherwise we think the inode is clean even if syncing failed.

The patch itself looks fine, but I'm not sure it's enough. If we do
an synchronous writeout it could fail long after ->write_inode
has returned.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/