Re: [PATCH] Repalce strncmp by memcmp

[AmÃrico Wang]

On Mon, Nov 29, 2010 at 05:09:10AM +0300, Pavel Vasilyev wrote:
>
>    This patch replace all strncmp(a, b, c) by  memcmp(a, b, c).
>
>I test on x86_64 (AMD Opteron 285).
>
>#include <string.h>
>char *A = "0000";
>void test_memcmp(void) {
>        memcmp(A, "TEST", 4);
>}
>void test_strn(void) {
>        strncmp(A, "TEST", 4);
>}

This is plain wrong, memcmp() doesn't handle the case that 'a'
is shorter than 'b', it may access beyond '\0'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/