Re: [PATCH] ARM: Gemini: Add support for PCI Bus

[Michał Mirosław]

2010/11/20 Hans Ulli Kroll <ulli.kroll@xxxxxxxxxxxxxx>:
> Add support for PCI Bus on Gemini Devices SL3516
>
> Signed-off-by: Hans Ulli Kroll <ulli.kroll@xxxxxxxxxxxxxx>
> ---
[...]
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a19a526..5d4b398 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -307,6 +307,7 @@ config ARCH_GEMINI
>        select CPU_FA526
>        select ARCH_REQUIRE_GPIOLIB
>        select ARCH_USES_GETTIMEOFFSET
> +       select PCI
>        help
>          Support for the Cortina Systems Gemini family SoCs
>
[...]

I think it's better to add ARCH_GEMINI to CONFIG_PCI dependencies.
AFAIK IB-4220B NAS does not use PCI and doesn't need all that code.
Board support entries could select PCI if the board is useless without
it.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/