Re: [PATCH v3 1/1] USB: cns3xxx: Add EHCI and OHCI bus glue forcns3xxx SOCs

[Alan Stern]

On Thu, 25 Nov 2010, Greg KH wrote:

> On Thu, Nov 25, 2010 at 07:21:58PM +0300, Anton Vorontsov wrote:
> > On Thu, Nov 25, 2010 at 11:58:00PM +0800, mkl0301@xxxxxxxxx wrote:
> > > From: Mac Lin <mkl0301@xxxxxxxxx>
> > > 
> > > The CNS3XXX SOC has include USB EHCI and OHCI compatible controllers. This
> > > patch adds the necessary glue logic to allow ehci-hcd and ohci-hcd drivers to
> > > work on CNS3XXX
> > > 
> > > The EHCI and OHCI controllers share a common clock control and reset bit,
> > > therefore additional check for the timming of enabling and disabling is
> > > required. The USB bit of PLL Power Down Control is also shared by OTG, 24MHz
> > > UART clock, Crypto clock, PCIe reference clock, and Clock Scale Generator.
> > > Therefore we only ensure it is enabled, while not disabling it.
> > > 
> > > Signed-off-by: Mac Lin <mkl0301@xxxxxxxxx>
> > 
> > Thanks for the patch!
> > 
> > Cc'ing Greg.
> > 
> > Greg, the patch doesn't touch any sensitive parts of EHCI and OHCI
> > drivers, can I take it via ARM subtree? This is to not introduce
> > cross-tree dependencies (the patch depends on some arch-specific
> > changes).
> 
> Please get Alan Stern to ack it as well, as he knows the proper
> callbacks that you need to ensure are present.

As far as the callbacks are concerned, this looks fine.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/