Re: [PATCH] Revert "kconfig: Temporarily disable dependency warnings"

[Catalin Marinas]

On 25 November 2010 17:16, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
> On Sun, Nov 21, 2010 at 9:57 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>> On Sun, 21 Nov 2010 20:58:54 -0500 Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
>>> There is 2 patches which fixes that by adding to the kconfig language
>>> a "visible" property to menus, 1 revert of "another" solution (which
>>> works but does not scale) and 2 patch which makes usage of the new
>>> property. Ack-ed and complemented by Mauro, but still waiting
>>> review/blessing by Michal.
>>>
>>> The core change is available here: https://patchwork.kernel.org/patch/306412/
>>>
>>> Alternatively, if you don't care about the menu structure, Randy
>>> proposed a one-liner.
>>
>> OK, good to know it is being worked on. ÂThanks.
>>
> FYI, I withdrawn the patches and ask for them not to be merged[0], as
> there is a clear lack of interest to see this issue resolved.
>
> Mauro, may I ask you to remove my patches from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-next.git
> kconfig_fixes

I still think the patches are useful. The fact that you didn't get any
comments from Michal doesn't mean that they are a bad idea, just lack
of time on the kbuild maintainer's side. It may have been a better
idea to cc LKML as well when you posted them (I for one don't follow
the kbuild list).

As for waiting times, I had patches taking even two years to get
merged. And my kbuild patch which actually introduced such warnings
had been around for nearly a year.

Now, commenting on your patches, you added a new statement, 'visible
if...' for menus. Can we not change it to something like:

-menu "I2C Algorithms"
-       depends on !I2C_HELPER_AUTO
+menu "I2C Algorithms" if !I2C_HELPER_AUTO

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/